Translate: improve error message when files do not start with "(define " #59
Conversation
victorpaleologue
force-pushed
the
issue1029
branch
from
e35e825 to
15f72db
Compare
In the translation algorithm, the assertion now contains some details about what went wrong in when a domain or a problem does not start with "(define ".
victorpaleologue
force-pushed
the
issue1029
branch
from
15f72db to
a15da1e
Compare
|
@maltehelmert This is the PR going along this issue http://issues.fast-downward.org/issue1029 |
|
I loved to meet you at ICAPS 2022! |
|
@FlorianPommerening who would you recommend me to ping with this? |
|
Hi @victorpaleologue, I'd normally suggest to use the tracker for pinging but this works as well. We would prefer to improve error reporting in a more general way, rather than fixing assertion messages that are not meant for error reporting. We have this on our list to look into at our next sprint in January and if we can make some progress there, this should also cover reporting a missing "(define". If we don't manage to merge something larger by February, we can merge this diff as a stopgap so it doesn't stay open forever. |
|
The notification email from the tracker bounced. Can you check that your email address there is up to date? |
|
Right, thanks, I’ve just updated my e-mail address there.
I admit I would find it easier to merge it now and start your sprint on top of that (and clean that away if it becomes pointless), rather than trying to rebase it on refactored code.
But I am not in your seat, and I should comply to the maintainers' plans.
… Le 5 déc. 2022 à 11:48, Florian Pommerening ***@***.***> a écrit :
The notification email from the tracker bounced. Can you check that your email address there is up to date?
—
Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACD4ZXD4ORCZYZDCKQRX6ILWLXB6PANCNFSM5ATBPVEA>.
You are receiving this because you were mentioned.
[ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#59 (comment)", "url": "#59 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]
|
FlorianPommerening
force-pushed
the
main
branch
6 times, most recently
from
27d6a14 to
c2a93e6
Compare
|
Superseded by #155, so I'm closing this. But thank you for bringing this to our attention! This was what ultimately triggered the more extensive rewrite of the PDDL parser. |
No description provided.